primevue icon indicating copy to clipboard operation
primevue copied to clipboard

SelectionButton: Not following dark mode

Open xarthurx opened this issue 1 year ago • 3 comments

Describe the bug

Using the darkModeSelector to change color mode. SelectionButton is not following the logic:

Light/Dark Mode: image image

Reproducer

https://stackblitz.com/edit/primevue-nuxt-issue-template

PrimeVue version

4.0.0-beta.5

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

Chrome

Steps to reproduce the behavior

Your stackblitz templete for nuxt is not working. But this bug should be very easy to test out.

Expected behavior

SelectionButton also follows the color logic.

xarthurx avatar Jun 30 '24 16:06 xarthurx

Hi @xarthurx, unfortunately, I couldn't replicate this. Could you please create a runnable project for us to replicate? Also, could you please try it with latest PrimeVue version?

Best Regards,

mertsincan avatar Jun 30 '24 20:06 mertsincan

We're unable to replicate your issue, if you are able to create a reproducer or add details please edit this issue. This issue will be closed if no activities in 20 days.

github-actions[bot] avatar Jun 30 '24 20:06 github-actions[bot]

Hi @xarthurx, unfortunately, I couldn't replicate this. Could you please create a runnable project for us to replicate? Also, could you please try it with latest PrimeVue version?

Best Regards,

I've never used stackblitz before. Could you fix your nuxt template so that I can directly copy code into it?

xarthurx avatar Jul 01 '24 07:07 xarthurx

No problem, yes you can use our example to provide your test case.

mertsincan avatar Jul 01 '24 07:07 mertsincan

No problem, yes you can use our example to provide your test case.

https://stackblitz.com/edit/primevue-nuxt-issue-template This is broken.

xarthurx avatar Jul 01 '24 14:07 xarthurx

No problem, yes you can use our example to provide your test case.

Could you fix your official template so that we can submit reproducible examples? All your template on stackblitz is not accessable.

xarthurx avatar Jul 02 '24 08:07 xarthurx

OK. I dig a bit into this problem, and it turns out the darkModeSelector is not working as expected.

As also asked here: https://github.com/primefaces/primevue/issues/5515

The documentation for how to apply dark mode is quite vague... Is the dark tag my-app-dark or dark or whatever is added to the html element or to each of PrimeVue's class? Is there any detailed explanation about how it works?

Is there a preset in any of the preset style (aura for instance) for dark mode, or we need to manually add the css for dark mode?

xarthurx avatar Jul 02 '24 08:07 xarthurx