primevue icon indicating copy to clipboard operation
primevue copied to clipboard
verified publisher icon primefaces

Fix positioning of overlay arrows

Open ajm13 opened this issue 1 year ago • 1 comments

###Defect Fixes This fixes https://github.com/primefaces/primevue/issues/5915

A few things:

  • ConfirmPopup was defining overlay.arrow.left but there were no references to overlay design token
  • Popover defines popover.arrow.left, but only uses popover.arrow.offset
  • I renamed overlay.arrow.left to confirmpopup.arrow.left to follow convention (there is an existing confirmpopup.arrow.offset)
  • I added arrow.left in the arrow CSS, as I believe the separate token arrow.offset was meant for a fixed offset based on arrow size

Result:

  • Calculated arrow.left values for confirmpopup and popover are actually used in the positioning of the arrow to make it dynamic based on screen location. arrow.offset token is still used for arrow theming.

ajm13 avatar Jun 27 '24 03:06 ajm13

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 3:31am
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 3:31am

vercel[bot] avatar Jun 27 '24 03:06 vercel[bot]