primevue icon indicating copy to clipboard operation
primevue copied to clipboard

Published 20 hours ago • verified publisher icon primefaces

Add filter functionality to treeselect component

Open zwik opened this issue 1 year ago • 4 comments

###Defect Fixes The TreeSelect component is missing filter functinality. The PR adds that functionality. Here's an issue that requests this feature: https://github.com/primefaces/primevue/issues/2832

###Feature Requests The TreeSelect component is missing filter functinality. The PR adds that functionality. As the functionality already exists in the Tree component I think this is not a very big change.

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.

zwik avatar Jan 19 '24 12:01 zwik

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 6:58pm

vercel[bot] avatar Jan 19 '24 12:01 vercel[bot]

Thanks for the PR. A behavior like in PrimeReact can be considered. We don't plan to add a close button, but we think they should be similar in terms of accessibility. For example, when the TreeSelect panel is opened in the filter demo, the filter input will be expected to be focused.

If you plan to add it, we would be happy to review it.

Thanks,

tugcekucukoglu avatar Jan 24 '24 10:01 tugcekucukoglu

Thank you for looking into this @tugcekucukoglu, I'm not sure if I understand you correctly. When I open the TreeSelect on my branch and it shows the tree with the filter, the filter does automatically gets focus. I've tested this in Chrome, Firefox and Edge, I don't have access to Safari though. am I missing something?

zwik avatar Jan 24 '24 12:01 zwik

@tugcekucukoglu : I fixed an issue where when you change from one TreeSelect to another the filter is indeed not focussed, the focus now works in every(?) situation. It would be great if this can be reviewed/merged soon :) . Many thanks in advance!

zwik avatar Jan 29 '24 10:01 zwik

Hello, I'm wondering if I need to do something still. Can I please get an update? Many thanks in advance!

zwik avatar Feb 27 '24 08:02 zwik

Version 4 will come with major changes. TreeSelect is one of the components that will be affected by this. We are closing this issue to avoid creating breaking change.

Appreciate your time and effort.

tugcekucukoglu avatar Mar 14 '24 12:03 tugcekucukoglu