primereact icon indicating copy to clipboard operation
primereact copied to clipboard
verified publisher icon primefaces

Added new capabilities and properties to Column and Dialog

Open didix16 opened this issue 1 year ago • 8 comments

This fixes some problmes with autocomplete component with dialog Issue #6569

didix16 avatar May 11 '24 20:05 didix16

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 9:26am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 9:26am

vercel[bot] avatar May 11 '24 20:05 vercel[bot]

Ok let me think about a better name for the prop then!

melloware avatar May 12 '24 18:05 melloware

Perfect, thanks! By the way, should I set onKeyDown event prevention to be done always and remove the Dialog property?

didix16 avatar May 12 '24 19:05 didix16

Yes just default that on key down

melloware avatar May 12 '24 20:05 melloware

I just removed the property added to Dialog and now the onKeyDown propagation event is stoped by default. Also I restored back the Dialog api.

didix16 avatar May 12 '24 22:05 didix16

I've applied the remaining changes. Removed the unused property and changed the other one. It should be ready to go.

didix16 avatar May 13 '24 21:05 didix16

@melloware I've removed a typo in BodyCell.js that formatter checker was preventing to merge the code. Hope now can pass the merge process...

didix16 avatar May 14 '24 09:05 didix16

Assigned to PrimeTek for review!

melloware avatar May 14 '24 11:05 melloware

Looks good! Superb

nitrogenous avatar May 15 '24 08:05 nitrogenous