primereact
primereact copied to clipboard
Fix #6068: Sidebar "Pass Through" documentation issue
Defect Fixes
Fixed #6068 Sidebar "Pass Through" documentation issue.
Options 3,4,5 and 6 did not match with the Wireframe. I fixed the 4,5 and 6 mismatching with this PR.
Current preview:
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
primereact | ⬜️ Ignored (Inspect) | Visit Preview | Mar 14, 2024 0:49am | |
primereact-v9 | ⬜️ Ignored (Inspect) | Visit Preview | Mar 14, 2024 0:49am |
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.
How did you do this did you edit this file? It is auto generated i think the main SideBarbase.js has to be updated?
Actually you have to fix the order in sidebar.d.ts
then it will re-generate the docs in that order.
Actually you have to fix the order in
sidebar.d.ts
then it will re-generate the docs in that order.
Thank you very much. I will update the PR.
after you make the changes to .d.ts
then run npm run build:api
that will regenerate the index.json from your TS changes.
Hi @melloware I fixed options 4,5 and 6.
I am not sure about option 3 in the wireframe. Before modifying the "Sidebar PT Options" I think it should update the wireframe.
The wireframe is out of our control PrimeTek does that. The best we can do is fix the TS docs...
I got it. Thank you very much for approving the PR.
Thank you for your contribution. We are actually thinking about a new system for more dynamic wireframes. We are open for ideas.
You are welcome. I look forward to more contributions.