primereact icon indicating copy to clipboard operation
primereact copied to clipboard

Fix #6068: Sidebar "Pass Through" documentation issue

Open charithAmila opened this issue 11 months ago • 2 comments

Defect Fixes

Fixed #6068 Sidebar "Pass Through" documentation issue.

Screen Shot 2024-02-29 at 3 45 20 PM Screen Shot 2024-02-29 at 3 49 00 PM

Options 3,4,5 and 6 did not match with the Wireframe. I fixed the 4,5 and 6 mismatching with this PR.

Current preview: Screen Shot 2024-03-01 at 12 20 35 AM

charithAmila avatar Mar 01 '24 04:03 charithAmila

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 0:49am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 0:49am

vercel[bot] avatar Mar 01 '24 04:03 vercel[bot]

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

github-actions[bot] avatar Mar 01 '24 04:03 github-actions[bot]

How did you do this did you edit this file? It is auto generated i think the main SideBarbase.js has to be updated?

melloware avatar Mar 01 '24 13:03 melloware

Actually you have to fix the order in sidebar.d.ts then it will re-generate the docs in that order.

melloware avatar Mar 01 '24 13:03 melloware

Actually you have to fix the order in sidebar.d.ts then it will re-generate the docs in that order.

Thank you very much. I will update the PR.

charithAmila avatar Mar 01 '24 14:03 charithAmila

after you make the changes to .d.ts then run npm run build:api that will regenerate the index.json from your TS changes.

melloware avatar Mar 01 '24 14:03 melloware

Hi @melloware I fixed options 4,5 and 6.

I am not sure about option 3 in the wireframe. Before modifying the "Sidebar PT Options" I think it should update the wireframe.

Screen Shot 2024-03-01 at 9 57 38 AM

charithAmila avatar Mar 01 '24 15:03 charithAmila

The wireframe is out of our control PrimeTek does that. The best we can do is fix the TS docs...

melloware avatar Mar 01 '24 15:03 melloware

I got it. Thank you very much for approving the PR.

charithAmila avatar Mar 01 '24 15:03 charithAmila

Thank you for your contribution. We are actually thinking about a new system for more dynamic wireframes. We are open for ideas.

nitrogenous avatar Mar 15 '24 15:03 nitrogenous

You are welcome. I look forward to more contributions.

charithAmila avatar Mar 15 '24 15:03 charithAmila