primereact icon indicating copy to clipboard operation
primereact copied to clipboard

Refactor KeyFilter

Open melloware opened this issue 1 year ago • 1 comments

###Defect Fixes @mertsincan this uses event.key which is much more browser standard than the old event.which etc and is much more reliable.

It also allows us to remove all the special Safari and Opera and Mozilla handling this class was doing.

Here is a great Keyboard event viewer: https://w3c.github.io/uievents/tools/key-event-viewer.html

Also its universally supported now: https://caniuse.com/?search=event.key

Its a start of refactoring for #2101

melloware avatar Jul 24 '22 12:07 melloware

Also it looks like this code originated from PrimeNG so it was proabbly valid a long time ago with these IE and Opera etc fixes none of which should be necessary now.

melloware avatar Jul 24 '22 13:07 melloware

@melloware can you create a Github issue?

mertsincan avatar Aug 26 '22 01:08 mertsincan

Yep

melloware avatar Aug 26 '22 02:08 melloware

Done!

melloware avatar Aug 26 '22 02:08 melloware