primeng icon indicating copy to clipboard operation
primeng copied to clipboard

fix(table): total records logic

Open Bock92 opened this issue 10 months ago • 4 comments

Fix: https://github.com/primefaces/primeng/issues/17569

Changes in this fix:

  • The totalRecords input property was not considered when calculating the total number of elements, regardless of whether the table was filtered or not.

Implementation Details:

  • The _totalRecords property now correctly represents the original value of @Input() totalRecords.
  • When p-table calculates the total number of records, it will first check if @Input() totalRecords is a valid number.
  • If totalRecords is not valid/set, the table will default to using value.length as the total record count.

Bock92 avatar Feb 12 '25 11:02 Bock92

Deployment failed with the following error:

Creating the Deployment Timed Out.

vercel[bot] avatar Feb 12 '25 11:02 vercel[bot]

@cetincakiroglu do you know if this PR is still under review?

The related issue still appears to be unresolved, so if possible, it would be great to close this PR soon. Let me know if there's anything I can do to help move it forward.

CC: @cagataycivici

Bock92 avatar Apr 29 '25 12:04 Bock92

How this issue it still not fixed???

@cetincakiroglu @cagataycivici

ZeroSkill830 avatar May 26 '25 15:05 ZeroSkill830

Tables are not really usable using an API. Guys, this is critical to be fixed.

CC: @cagataycivici

macx avatar Jun 12 '25 07:06 macx

Thanks a lot for your contribution!

mertsincan avatar Jul 09 '25 10:07 mertsincan