primeng
primeng copied to clipboard
primefaces
Calendar - add option to change step size in yearpicker
Hi,
This is my first time contribution. I am not sure about the standard operating procedure. If I made a mistake, please point me in the right direction.
As suggested by the contribution-guidelines, I opened a discussion: https://github.com/orgs/primefaces/discussions/1780
After reading the text in the PR-template (see below), I am no longer certain such a discussion is necessary, since this is a small scale feature.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes. Smaller scaled feature implementations such as adding a property to a component will be considered for merging.
I think this qualifies as "Smaller scaled feature implementations".
Here is what this PR does:
It changes the default step-size for the year picker from 10 to 20 [1]. And it adds a input-parameter to change the stepsize [2]
In the discussion I explain, why I think this feature is usefull. (But I guess it would be ok to let the discussion-page die, and instead move discussions here)
[1]:
[2]:
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| primeng | ⬜️ Ignored (Inspect) | Visit Preview | May 1, 2024 9:03pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Could you please confirm how this appears on mobile and tablet screens? I'm concerned that the default step size might cause some parts to be cut off.
size 20 on firefox/galaxy s10:
size 20 on chrome/galaxy s8
size 10 on firefox/galaxy s10:
I feel like these buttons are too small to be comfortable on mobile. But I guess that would be a different issue.
sorry for forcepushing.
I squashed some commits, that would add clutter individually. Also I forgot to setup name/mail for git on this machine, and I didn't want "Your Name " and "Your Mail" to pollute the history.
Hi,
Could you please create an issue and link the PR with the issue?
I can not create an issue (I think?). I can only report bugs. When I click the "feature request" button, I get redirected to the discussion page
I completely missed the "open a blank issue" button, sorry.
I now made the issue, as requested: https://github.com/primefaces/primeng/issues/15634
Hi,
Thanks for the effort and support, merging the PR and making it 10 as default value.