fixed #14807 #14252 #14603 - updated onToggleAll method to call onChange and onSelectAllChange

[rosenthalj]

Fix #14807 Fix #14252 Fix #14603

I updated the onToggleAll method to call onChange.emit and onSelectAllChange.emit. Special logic was add to determine whether or not onSelectAllChange.emit should be called since a user could be filtering.

The first video shows the issue #14807 reproducer (which I created based on the steps provided in the issue) working after the fix. Note: the end of the video shows how the changes work when the user filters before toggling on and off

https://github.com/primefaces/primeng/assets/45439491/8cb5feb5-81d1-4365-b306-62250ee9f5d3

The second video shows the issue #14252 reproducer working after the fix. Note: the end of the video also shows how the changes work when the user filters before toggling on and off

https://github.com/primefaces/primeng/assets/45439491/9bedc69d-9038-4ffd-97a3-0f4d35259d00

The third video shows issue #14603 fixed, the PimeNG table filter-menu demo is fixed with this pull request

https://github.com/primefaces/primeng/assets/45439491/d250bc8d-9f44-49bf-87d7-65ce1cd7c869

This PR supersedes PR #14604

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Feb 16, 2024 4:02pm

[miki995]

@cetincakiroglu @mehmetcetin01140 ??? Can this be merged please, it is crucial thing we use in our project?

Thanks for understanding...

[cetincakiroglu]

Hi @rosenthalj

Thanks a lot for the effort and support!