primeng
primeng copied to clipboard
primefaces
Fixed #14815 - Dropdown | Selected option not shown while typing in f…
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| primeng | ⬜️ Ignored (Inspect) | Feb 15, 2024 2:18pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
I believe this PR will partially fix the issue.
If the user types in letters that never match an option value then the change works. If the user types in letters that match a different option then the issue still occurs.
The video listed below shows the current PR partially working.
https://github.com/primefaces/primeng/assets/45439491/4580fa02-69d3-4334-9078-320d1ac8b483
Updating this PR with the following additional change will fix fully the issue:
The video listed below shows the PR with my proposed change fully working.
https://github.com/primefaces/primeng/assets/45439491/e9d231fa-b8eb-4e9c-8f6d-379131f43502
@cetincakiroglu,
I just received an email that you closed issue #14815. I immediately downloaded the current master branch and it appears that this issue has not been fixed. I compared the changes to dropdown.ts to this PR #14820 (including my proposed additional changes that I provided as a comment) and it appears that all the PR changes were superseded by a different approach. Unfortunately the changes to dropdown.ts doesn't fix issue #14815.
The video listed below is using the Issue #14815 reproducer with most recent master changes and shows that issue #14815 is back to its v17.7.0 broken state.
https://github.com/primefaces/primeng/assets/45439491/d60fa2b7-ee82-48c7-b9aa-3b8b5670f13c