primeng
primeng copied to clipboard
primefaces
Fix p-autoComplete: selected item template is not displayed
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| primeng-ssr-test | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2023 9:01am |
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| primeng | ⬜️ Ignored (Inspect) | Jul 2, 2023 9:01am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @Tuxio ,
Thank you for taking the time to submit your pull request. We genuinely appreciate your effort and interest in improving our project.
After careful review and consideration, we have decided not to merge your pull request at this time. Please understand that this decision does not reflect negatively on the quality of your work. We value every contribution and understand the effort you've put into it.
However, upon review, we believe that the changes proposed in this pull request may not align with the current goals or direction of the project. Our team is continuously evaluating and prioritizing features and enhancements based on various factors, including project roadmap, user feedback, and technical considerations. selectedItem template support will be implemented for singular input mode also in the future.
We encourage you to continue contributing to the project and to stay engaged with our community. Your input and contributions are valuable, and we look forward to seeing more of your work in the future.
Once again, thank you for your contribution, and please don't hesitate to reach out if you have any questions or would like further feedback.
Best regards,
@cetincakiroglu the selectedItem Template doesnt work since several major versions. Here someone does the work and fixes it and it is ignored.
@uebelmar,
selectedItem template is only supported for multiple mode. It's not broken feature, it's not supported in single mode. We've closed the PR because:
1-) Styling becomes broken, and unnecessary outline can bee seen w/keyboard. 2-) Styles should be applied in primeng-sass-theme not in component CSS. Padding and margin values change depending on the applied theme. In this way, they will always be the same. 3-) We can't apply min-width to the styles. 4-) Dom structure changes and it's a breaking change. 5-) Also even the example doesn't work correctly. See the image, you can also see that weird size difference in second image. 6-) It breaks accessibility, the overlay shouldn't open by down arrow, also the overlay cannot be opened by search in the example which is default behavior. 7-) In the third image, you can enter input simultaneously while the selection is also rendered, which is the default behavior of multiple mode, it doesn't function correctly. If it's the use case, same thing can be applied achieved by restricting input count by 1 using multiple. The result will be the same.
So it's not ignored, it's reviewed and closed. We can't merge a feature that doesn't function correctly.
@cetincakiroglu
Thank you for taking the time to explain. That of course makes sense. I also saw in another issue that you have support for selectedItem in single mode on the feature list.
Another thing to think about is that the documentation for the selectedItem template mentions that it is only supported in single mode. In the last few years there have been a few Github issues and StackOverflow articles that have come across this.
@cetincakiroglu
Thank you for taking the time to explain. That of course makes sense. I also saw in another issue that you have support for selectedItem in single mode on the feature list.
Another thing to think about is that the documentation for the selectedItem template mentions that it is only supported in single mode. In the last few years there have been a few Github issues and StackOverflow articles that have come across this.
Yes we'll update the docs to indicate that it's not supported in multiple mode