primeng icon indicating copy to clipboard operation
primeng copied to clipboard

fix(primeng/p-password): incorrect class assignment for `true` value of `toggleMask` in the password component.

Open volvachev opened this issue 3 years ago • 1 comments

The problem appeared during fix of the bug #10716 (running detectChanges in pInputText). Setter has been ran by detector without running doCheck inside ngClass.

To avoid the problem, either do not run detectChanges inside pInputText or do not use methods inside the template, for example: replace them with pipes, or call the detectChanges method inside ngAfterViewInit(p-password) as well.

To solve the problem, I have decided to use pipes because this is the best solution from my point of view. But if you want to replace the detectChanges call, I will do it

Defect Fixes #11356, #11408.

volvachev avatar Apr 13 '22 12:04 volvachev

Thanks @volvachev

Please, I need this fix <3

JuanSeBestia avatar Aug 30 '22 21:08 JuanSeBestia

Thanks a lot for your contribution, @volvachev ;)

mertsincan avatar Nov 08 '22 10:11 mertsincan