primeng icon indicating copy to clipboard operation
primeng copied to clipboard

Readonly arrays for p-dropdown and p-splitbutton

Open papb opened this issue 3 years ago • 4 comments

Fixes #8609

papb avatar Feb 07 '22 03:02 papb

I was hoping to see automated tests running when I opened the PR, but apparently there aren't any.

papb avatar Feb 07 '22 03:02 papb

It correct my current problem. Good !

I am thinking to add 1 unit test per modified component, to ensure no regression on readonly collections. I would have time to do that before Monday.

worming004 avatar Mar 10 '22 10:03 worming004

Here it is, have a look on https://github.com/papb/primeng/pull/1 to have few more unit test to cover this change

worming004 avatar Mar 18 '22 13:03 worming004

Ready for review!

papb avatar Jun 05 '22 19:06 papb

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Jan 12 '23 01:01 github-actions[bot]

Still relevant. Still waiting for someone to review and merge.

papb avatar Jan 16 '23 16:01 papb

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar May 17 '23 01:05 github-actions[bot]

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you for your understanding!

github-actions[bot] avatar May 25 '23 01:05 github-actions[bot]

Please reopen

papb avatar May 30 '23 01:05 papb