primeng
primeng copied to clipboard
Readonly arrays for p-dropdown and p-splitbutton
Fixes #8609
I was hoping to see automated tests running when I opened the PR, but apparently there aren't any.
It correct my current problem. Good !
I am thinking to add 1 unit test per modified component, to ensure no regression on readonly collections. I would have time to do that before Monday.
Here it is, have a look on https://github.com/papb/primeng/pull/1 to have few more unit test to cover this change
Ready for review!
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize reviewing it yet. Your contribution is very much appreciated.
Still relevant. Still waiting for someone to review and merge.
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize reviewing it yet. Your contribution is very much appreciated.
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you for your understanding!
Please reopen