primeng icon indicating copy to clipboard operation
primeng copied to clipboard

p-multiselect: Performance fix when selecting all items (10000 records or more)

Open ManojKChowdhury opened this issue 4 years ago • 6 comments

###Defect Fixes In scenarios when there are huge numbers of records in the multiselect dropdown, activating virtual scroll enables smooth open-close of the dropdown. But upon clicking the select-all checkbox:

  • It takes around 13-14 seconds for the checkbox to be shown as selected and the dropdown to be usable again.
  • The page becomes unusable during this duration.
  • Closing the dropdown now and re-opening it with all items selected also takes a lot of time.
  • De-selecting all items by clicking on the checkbox again takes considerable time.

Hence the changes in this commit aim to tackle this issue. Fixes #10695

ManojKChowdhury avatar Sep 29 '21 13:09 ManojKChowdhury

@ManojKChowdhury your code changes doesn't work for me to improve

  • Initial loading time
  • check all/uncheck all page unusable issue.

If possible create a fiddle for POC

TUSHAR4541 avatar Nov 22 '21 11:11 TUSHAR4541

It works for me, even with 10000 records! What are the options that you are setting on the p-dropdown?

ManojKChowdhury avatar Dec 28 '21 08:12 ManojKChowdhury

We are facing similar issue and following are the options we are setting

<p-multiSelect
    [options]="options"
    [optionLabel]="optionLabel"
    [optionValue]="optionValue"
    [placeholder]="placeholder"
    [(ngModel)]="selectedOptions"
    [virtualScroll]="virtualScroll"
    [itemSize]="itemSize"
    ></p-multiSelect>

We have around 4000 records

osamayawar avatar Jul 20 '22 14:07 osamayawar

Thanks a lot for the PR! But, please see my comment; https://github.com/primefaces/primeng/issues/10695#issuecomment-1190387255 Maybe, you can update your PR like in PrimeReact.

Best Regards,

mertsincan avatar Jul 20 '22 14:07 mertsincan

@ManojKChowdhury can you please take a look or rather @mertsincan can you ask someone from your team to create a new PR for it? Would be of great help !!

osamayawar avatar Jul 20 '22 15:07 osamayawar

Do we have an ETA for this fix?

osamayawar avatar Jul 28 '22 12:07 osamayawar

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Nov 28 '22 01:11 github-actions[bot]

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you for your understanding!

github-actions[bot] avatar Dec 06 '22 01:12 github-actions[bot]