design-system
design-system copied to clipboard
Responsive Image Component
My team followed TSP and created a new component to display responsive images using srcset. Now, the developers using this design system can use this component to give multiple URLs of images that need to be displayed depending on the viewport size.
Also, the 'rush create' command is missing from your scripts, so we were not able to follow the procedure mentioned in the document but we have thoroughly tested our component for any errors and corrected if found any.
Hey @AyushRathi07, thanks for contributing! Many of us are out of office for the holidays, but we'll review this the next time our working group meets.
Sure sir, thanks for letting me know.
👋🏼 @AyushRathi07, thanks for contributing. A few thoughts have been shared w. other authors that we'd just give you a collective feedback, to hopefully, guide the PR to work towards completion. PTAL?
- we definitely could correlate to the use case for a responsive image; although, we've already have
Image
written in our common adaptation of styled-component and styled-system. Wonder if you could coalesce your feature into the code ofImage
-
ResponsiveImage
, as a name, may change in future round of reviews with feedback from other authors, but it'd be possible to start with making an alias ofResponsiveImage
We wonder if you could take a look at Image
, and try to edit for the next round of review?
cc/ @craigpalermo