design-system icon indicating copy to clipboard operation
design-system copied to clipboard

New Component: Tabs

Open abautist opened this issue 6 years ago • 2 comments

I built a generalized tabs component that is flexible enough to be shareable across the org. Would it be appropriate to add it as an optional package associated with the design system (similar to carousel, modal..)?

If this is a direction we'd be interested in going, I can create a PR to continue the discussion.

abautist avatar Dec 04 '18 19:12 abautist

+1 for building tab component to v2 packages/ workspace.

But does "bare-bones" mean no design at all? Can confirm in next WG meeting about any general design for tab component.

BeniCheni avatar Dec 04 '18 22:12 BeniCheni

The component is styled in PCLN's DS theme. Bare bones in that the only functionality is clicking the tab labels to change active tab and display active tab's content. Content can be composite components, so hopefully super flexible/customizable. I'll open a PR to solicit more feedback on the code.

Example designs: screen shot 2018-12-06 at 3 41 07 pm

screen shot 2018-12-04 at 2 35 25 pm

abautist avatar Dec 06 '18 20:12 abautist