craft.js icon indicating copy to clipboard operation
craft.js copied to clipboard

@craftjs/util missing peer dependency for react-dom

Open jimmiebtlr opened this issue 3 years ago • 2 comments

Describe the bug Utils package imports react-dom, but doesn't have it listed in peer dependencies of the package.

On a side note, this seems to be treated as an error by yarn v3 (at least in pnp mode).

jimmiebtlr avatar Jun 08 '22 08:06 jimmiebtlr

have you tried https://yarnpkg.com/configuration/yarnrc#packageExtensions in yarn 3 to fix this

CarlosBalladares avatar Jun 21 '22 22:06 CarlosBalladares

I was able to get it working with package extensions, thanks. From what I understand, I think this should also be updated in the package though? I'm pretty novice with npm packaging though, so let me know if this should be closed.

jimmiebtlr avatar Jun 22 '22 06:06 jimmiebtlr