http-status-codes icon indicating copy to clipboard operation
http-status-codes copied to clipboard

Published 20 hours ago • verified publisher icon prettymuchbryce

Missing status codes for newtork failures

Open victorpers opened this issue 3 years ago • 6 comments

Superagent has a retry method which use the following status codes :

  • 408
  • 413
  • 429
  • 500
  • 502
  • 503
  • 504
  • 521
  • 522
  • 524

You will find the official documentation of this retry method here : https://visionmedia.github.io/superagent/#retrying-requests

Status codes 521, 522 and 524 are not supported by this lib, could it be possible to add them ?

victorpers avatar Feb 21 '22 09:02 victorpers

Do we still need this? i can work on this issue

angelsupp avatar Sep 17 '23 14:09 angelsupp

http-status-codes

mh9ea6ec9nk4a avatar Oct 05 '23 11:10 mh9ea6ec9nk4a

Hdg

mh9ea6ec9nk4a avatar Oct 05 '23 11:10 mh9ea6ec9nk4a

I have been check and confirm, here is the update:

  • [x] 408
  • [x] 413
  • [x] 429
  • [x] 500
  • [x] 502
  • [x] 503
  • [x] 504

Only left these status-code below:

  • [ ] 521
  • [ ] 522
  • [ ] 524

cc: @victorpers , @prettymuchbryce .

angellee177 avatar Nov 08 '23 16:11 angellee177

521/522/524 are all Cloudflare-specific status codes without official IETF specs. However, because of the ubiquity of Cloudflare, I am OK with adding them, but we should specify this fact in codes.json, as well we should find pertinent documentation to link there as well (even though it won't be an official spec).

prettymuchbryce avatar Nov 13 '23 15:11 prettymuchbryce

i can work on it @prettymuchbryce . Noted, I'll add this fact in codes.json regarding the status codes without official IETF specs.

angelsupp avatar Nov 13 '23 17:11 angelsupp