tslint-config-prettier icon indicating copy to clipboard operation
tslint-config-prettier copied to clipboard

tslint rule `"quotemark": "avoid-template"` is not covered by prettier

Open jensbodal opened this issue 4 years ago • 2 comments

  "rules": {
    "quotemark": [
      true,
      "avoid-template"
    ]
  }

The above tslint rule prevents declaring strings like

const f = `f`

Prettier does not plan on supporting a rule like this: https://github.com/prettier/prettier/issues/4175

Is there a way that using the "avoid-template" rule with "quotemark" won't throw when running tslint-config-prettier-check? Or an option to whitelist a rule?

jensbodal avatar Oct 29 '19 17:10 jensbodal

Is there a way that using the "avoid-template" rule with "quotemark" won't throw when running tslint-config-prettier-check? Or an option to whitelist a rule?

Currently, tslint-config-prettier-check does not support whitelisting rule options, and I don't think we'll add support for it given that tslint itself is already deprecated (palantir/tslint#4534). PRs to add such support is still welcome, though.

ikatyang avatar Nov 01 '19 07:11 ikatyang

That's very interesting. @ikatyang do you think it could be a good idea to merge this library with eslint-config-prettier after that? You created a great setup in this lib that could be awesome to have it in eslint version!

alexjoverm avatar Apr 27 '20 09:04 alexjoverm