pretty-quick icon indicating copy to clipboard operation
pretty-quick copied to clipboard

pretty-quick --check is fixing files

Open elvirdolic opened this issue 4 years ago • 2 comments

Hi,

I wanted to use pretty-quick --check during CI to prevent that not formatted code is landing in master. But the --check property seems not to work correctly

pretty-quick version: 2.0.1

yarn pretty-quick 
yarn run v1.22.4
$ \node_modules\.bin\pretty-quick
�🔍  Finding changed files since git revision 159bf55e4.
�🎯  Found 1 changed file.
✍️  Fixing up add-user.actions.ts.
✅  Everything is awesome!
Done in 3.02s.
PS yarn pretty-quick --check  
yarn run v1.22.4
$ node_modules\.bin\pretty-quick --check
�🎯  Finding changed files since git revision 159bf55e4.
�🔍  Found 1 changed file.
✍️  Fixing up add-user.actions.ts.
✅  Everything is awesome!
Done in 2.47s.

--check and without check are doing the fixing but I just want to fail the job with --check flag

elvirdolic avatar Jun 04 '20 10:06 elvirdolic

Hey @elvirdolic. Are you still experiencing this? This isn't the expected behaviour at all. If you are able to gather some extra diagnostic info that would go a long way to solving your issue.

azz avatar Aug 21 '20 01:08 azz

A minimal but runnable online reproduction is required.

JounQin avatar Jan 16 '24 11:01 JounQin