prettier icon indicating copy to clipboard operation
prettier copied to clipboard

feat: add support for @let syntax in Angular

Open eneajaho opened this issue 1 year ago • 2 comments

Hello, Angular is adding support for @let syntax in https://github.com/angular/angular/pull/55848.

Having prettier support that would be great!

eneajaho avatar May 17 '24 08:05 eneajaho

Feel free to submit a PR with the feature! I’m not an expert in Angular, but I guess that the change will look similar to #15777 (by @sosukesuzuki).

kachkaev avatar May 17 '24 11:05 kachkaev

Maybe we should merge upstream in prettier/angular-html-parser...

sosukesuzuki avatar May 17 '24 12:05 sosukesuzuki

Angular just released this feature, so now prettier is a blocker.

serg-mois-capital avatar Jul 10 '24 14:07 serg-mois-capital

Our angular parser's side pr https://github.com/prettier/angular-html-parser/pull/40

sosukesuzuki avatar Jul 11 '24 09:07 sosukesuzuki

Parser support has been added in #16466, @sosukesuzuki is implementing the print logic.

~Maybe we need support angular-estree-parser support to parse "Block-like syntax"? I don't know if it supports destructing, if not, we can use js parser to parse it as assignments.~ Misunderstood.

fisker avatar Jul 12 '24 05:07 fisker

Released 3.3.3

sosukesuzuki avatar Jul 13 '24 12:07 sosukesuzuki

Released 3.3.3

Excelent! Thanks. What about the prettier-vscode extension?

lucasousi avatar Jul 13 '24 18:07 lucasousi

Released 3.3.3

Excelent! Thanks. What about the prettier-vscode extension?

you can make prettier-vscode use a different prettier version by npm i -g prettier

tomasdev avatar Aug 01 '24 04:08 tomasdev

@sosukesuzuki I think the tests missed a case:

@let foo = 'hello';
{{ foo }}

In v3.3.3 is still getting reformatted to:

@let foo = 'hello'; {{ foo }}

tomasdev avatar Aug 01 '24 04:08 tomasdev

@tomasdev Please create new issue

sosukesuzuki avatar Aug 01 '24 10:08 sosukesuzuki

We have indeed encountered this problem and hope that the experts can solve it. The project has been upgraded to Angular 18, but after formatting, it's too bad.

xylplm avatar Aug 17 '24 08:08 xylplm

Locked due to age, if you have issues, please submit

fisker avatar Aug 17 '24 08:08 fisker