prettier-vscode icon indicating copy to clipboard operation
prettier-vscode copied to clipboard

Change the JSX bracket-same-line option to the new bracketSameLine one

Open gdamou opened this issue 4 years ago • 6 comments

Since a few weeks, prettier deployed an option which extends possibility to force bracket to close on the same line and not on a new line. The option is called bracketSameLine and replace jsxBracketSameLine but is not implemented yet on the vscode prettier's extension.

Do you guys think it is possible to implement this as well as it is on Prettier ?

Thanks for reading me.

gdamou avatar Oct 27 '21 14:10 gdamou

This is an issue or feature request for the Prettier library itself rather than the VS Code extension for prettier. Please open an issue at https://github.com/prettier/prettier.

ntotten avatar Nov 02 '21 23:11 ntotten

The feature already exist in the Prettier library as you can see there : https://prettier.io/blog/2021/09/09/2.4.0.html

gdamou avatar Nov 03 '21 10:11 gdamou

It will be very useful to add "bracketSameLine" rule to Prettier-VSCode settings.

ioagiannis avatar Nov 25 '21 14:11 ioagiannis

Can we please add this option? If bracketSameLine exists in the config file (.prettierrc.json) it gets ignored and you are forced to set the deprecated option. This creates a disparity between coworkers that use VSCode with this extension and those who call Prettier by themselves (on Vim, for example)

Avishayy avatar Jan 18 '22 08:01 Avishayy

This option still not available?

kskrlinnorth2 avatar Feb 15 '22 14:02 kskrlinnorth2

I'm using VS Code extension, and there's jsxBracketSameLine option only. That setting doesn't affect HTML files, which is what I'm hoping for. Any ideas on how to turn this rule for HTML files using Prettier VS code extension?

adrianbienias avatar Jul 22 '22 20:07 adrianbienias

Version 9.7.0

ntotten avatar Aug 20 '22 20:08 ntotten

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Nov 19 '22 00:11 github-actions[bot]