prettier-eslint icon indicating copy to clipboard operation
prettier-eslint copied to clipboard
verified publisher icon prettier

feat: cache ESLint instances for faster formatting

Open taye opened this issue 4 years ago • 2 comments

This PR speeds up repeated formatting by reusing the previously created ESLintCLIEngine instance when the eslintPath and eslintOptions that are passed to getESLintCLIEngine are identical.

:heart:

taye avatar Feb 06 '21 02:02 taye

Codecov Report

Merging #494 (f6f774d) into master (8f35b25) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #494   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          208       213    +5     
  Branches        42        43    +1     
=========================================
+ Hits           208       213    +5
Impacted Files Coverage Δ
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f35b25...f6f774d. Read the comment docs.

codecov-io avatar Feb 06 '21 03:02 codecov-io

Codecov Report

Merging #494 (0a7e1d1) into master (d6ef389) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #494   +/-   ##
=======================================
  Coverage   99.66%   99.67%           
=======================================
  Files           2        2           
  Lines         298      306    +8     
  Branches       88       92    +4     
=======================================
+ Hits          297      305    +8     
  Misses          1        1
Impacted Files Coverage Δ
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6ef389...0a7e1d1. Read the comment docs.

codecov-commenter avatar Jun 04 '22 12:06 codecov-commenter

Stale pull request

github-actions[bot] avatar Dec 16 '22 00:12 github-actions[bot]

@idahogurl I've rebased the source branch

taye avatar Mar 12 '23 14:03 taye

@taye GitHub isn's letting me Reopen the PR because it says since the force-pushed or recreated that you need to create a new PR.

idahogurl avatar Mar 13 '23 15:03 idahogurl