prettier-eslint icon indicating copy to clipboard operation
prettier-eslint copied to clipboard

feat(prettier): Respect editor config

Open kvetis opened this issue 3 years ago • 1 comments

Prettier has the ability to read .editorconfig while resolving the rules. These are read automatically when using the prettier CLI. If the .editorconfig file is not found the option is ignored and does not result in error.

This might introduce breaking change (in the author's case a fix, though) for the folks who have .editorconfig in their folder structure, but it is not in line with prettier config. There might be a legitimate reason for that, but I cannot think of any.

I did not feel this needed a new option to pass into prettier-eslint. I consider is more a discussion PR, since I don't know what you people think of the correct approach should be. So I just picked one solution and updated it. Maybe I could add a test that proves that the editorconfig works.

kvetis avatar Jan 18 '21 14:01 kvetis

Codecov Report

Merging #483 (0c52067) into master (8f35b25) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #483   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          208       208           
  Branches        42        42           
=========================================
  Hits           208       208           
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f35b25...0c52067. Read the comment docs.

codecov-io avatar Jan 18 '21 14:01 codecov-io

Stale pull request

github-actions[bot] avatar Dec 16 '22 00:12 github-actions[bot]