prettier-eslint
prettier-eslint copied to clipboard
feat(prettier): Respect editor config
Prettier has the ability to read .editorconfig
while resolving the rules. These are read automatically when using the prettier CLI.
If the .editorconfig
file is not found the option is ignored and does not result in error.
This might introduce breaking change (in the author's case a fix, though) for the folks
who have .editorconfig
in their folder structure, but it is not in line with prettier config.
There might be a legitimate reason for that, but I cannot think of any.
I did not feel this needed a new option to pass into prettier-eslint. I consider is more a discussion PR, since I don't know what you people think of the correct approach should be. So I just picked one solution and updated it. Maybe I could add a test that proves that the editorconfig works.
Codecov Report
Merging #483 (0c52067) into master (8f35b25) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #483 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 208 208
Branches 42 42
=========================================
Hits 208 208
Impacted Files | Coverage Δ | |
---|---|---|
src/index.js | 100.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8f35b25...0c52067. Read the comment docs.
Stale pull request