prettier-cli icon indicating copy to clipboard operation
prettier-cli copied to clipboard
verified publisher icon prettier

test: migrate config-precedence tests

Open 43081j opened this issue 9 months ago • 1 comments

Copies the config-precedence tests from prettier.

@fabiospampinato i could do with some help here. i haven't updated the snapshots yet since some of them are legitimate failures it seems (until we decide what to do)

basically seems like one or more of the tests expect CLI args to be overridden by config files, but we do the opposite

43081j avatar Mar 18 '25 20:03 43081j

I just checked the history, it's added in https://github.com/prettier/prettier/pull/2733 with lots of questions, basically, it was added only because someone may use the CLI without a config file.

I highly doubt anyone using it nowadays.

fisker avatar Mar 19 '25 02:03 fisker

@fisker Should we just delete the --config-precedence flag then?

fabiospampinato avatar Jun 14 '25 18:06 fabiospampinato

I agree to remove it. CLI flags should always take higher precedence.

fisker avatar Jun 14 '25 20:06 fisker

Removed support in c90b4e4, so I'm closing this.

fabiospampinato avatar Jun 14 '25 20:06 fabiospampinato