prettier-cli icon indicating copy to clipboard operation
prettier-cli copied to clipboard

fix(deps): support pre-release as allowed peer dependency

Open HugoPoi opened this issue 6 months ago • 0 comments

The problem

  • npm doesnt take pre-release as candidate versions so [email protected] isn't a valid version for ^3.1.0 || ^4.0.0
  • As a result without using npm --legacy-peer-deps, we can't use version 4

Capture d’écran du 2024-08-20 11-22-35

Suggested solution is to add pre-release allowed in peerDeps

require('semver').satisfies('4.0.0-alpha.9', '^3.1.0 || ^4.0.0'); // return false
require('semver').satisfies('4.0.0-alpha.9', '^3.1.0 || ^4.0.0-alpha'); // return true
require('semver').satisfies('4.0.12', '^3.1.0 || ^4.0.0-alpha'); // return true
require('semver').satisfies('4.0.0-beta.1', '^3.1.0 || ^4.0.0-alpha'); // return true
require('semver').satisfies('4.0.3-alpha.2', '^3.1.0 || ^4.0.0-alpha'); // return false

Workaround

Capture d’écran du 2024-08-20 11-28-26

PS: if this is the intended behavior please close this PR

HugoPoi avatar Aug 20 '24 09:08 HugoPoi