pretix icon indicating copy to clipboard operation
pretix copied to clipboard

Quickstart wizard: required fields marked as optional

Open luelista opened this issue 1 year ago • 1 comments

Problem and impact

When choosing "Payment by bank transfer" in the quickstart wizard, the bank detail fields are marked as optional, but are actually required.

Expected behaviour

Fields are marked as required

Steps to reproduce

No response

Screenshots

Bildschirmfoto vom 2023-08-03 16-26-24

Link

No response

Browser (software, desktop or mobile?) and version

No response

Operating system, dependency versions

No response

Version

No response

luelista avatar Aug 03 '23 14:08 luelista

Oh, yes. This is because they are "sometimes required" depending on what is selected above, which is a concept not known to the form renderer.

Since they are always either hidden or required, never visible and not required, a (very hacky, but working) fix could be replacing

                    {% bootstrap_field form.payment_banktransfer_bank_details_sepa_name layout="control" %}

with

                    {% bootstrap_field form.payment_banktransfer_bank_details_sepa_name layout="horizontal" %}

at least as long as the required labels are the only difference between those two renderers

raphaelm avatar Aug 07 '23 13:08 raphaelm