pokeyellow
pokeyellow copied to clipboard
pret
Disassembly of Pokemon Yellow
See https://github.com/pret/pokered/issues/271 for more discussion. ``` 1dc242039218fba50928d1afb66b70565b6b9daf *pokeyellow-es.gbc 42f3714eec6eca25200d42461ff08d57c98f6d1d *pokeyellow-de.gbc 0aceec0ef7aa2ca5aa831554598d91f61a925591 *pokeyellow-fr.gbc 05bb8e99f24d498613930949730afa8024e77d08 *pokeyellow-it.gbc ``` The Japanese and Chinese pirate ROMs probably deserve separate projects: ``` 1fb6c264e950d97ce3fd99b347e485b2150df4ff *pokeyellow-jp.gb 28e4b8531ea4ea1de5a396fccb0cfba51b06b149 *pokeyellow11-jp.gb...
The original names for the routines come from these commits: https://github.com/pret/pokeyellow/commit/6faafde364d4f21a2c88d4d60617f98b5d41a5b2 and https://github.com/pret/pokeyellow/commit/4571f8130eab92325d16e94330ae7f92f3ea7caa. They are a bit confusing since Yellow doesn't have an RTC. This PR also syncs pokeyellow with...
I couldn't find this variable in pokered either so I'm guessing that it's just a misstake. Going back in time in Githubs blame view makes me think that there was...
https://github.com/pret/pokeyellow/blob/cf5a7f02113265edc9369841ec986af3f47b64b1/engine/pikachu/pikachu_status.asm#L139-L179 From a glance, it seems that the two labels are wrong: At lines 162-164, a nonzero value of `a` means there is a status ailment, and 0 means no...
In scripts\Route24.asm, ``` Route24TrainerHeader5: trainer EVENT_BEAT_ROUTE_24_TRAINER_5, 1, Route24Youngster2BattleText, Route24Youngster2EndBattleText, Route24Youngster2AfterBattleText db -1 ; end ``` In text\Route24.asm ``` _Route24Youngster2BattleText:: text "This is NUGGET" line "BRIDGE! Beat us 5" cont "trainers...
In event_constants.asm, EVENT_BEAT_POKEMONTOWER_7_TRAINER_2 isn't referenced anywhere. Also, the name for EVENT_BEAT_POKEMONTOWER_7_TRAINER_1 seems incorrect. It isn't linked to an actual battle.
Added the name `StopBikeSurf` to the previously unnamed `Func_07c4`. This function is only present in yellow, and not red/blue, so submitting PR directly to this repo...