pokestadium Setup m2c

Setup m2c

Open Kelebek1 opened this issue 2 years ago • 6 comments

Oct 26 '22 09:10 Kelebek1

What's the point of this PR? What is the need to actually submodule this?

Oct 26 '22 10:10 RevoSucks

To make it easier? Don't see why we wouldn't include it given how required it is for decomps. Plus the repo has to change libultra to use m2c anyway.

A bunch more changes are needed to get diff and splat actually working as well...

Oct 26 '22 22:10 Kelebek1

What are you talking about? I've already fully integrated libultra.

Oct 26 '22 22:10 RevoSucks

See the ramrom.h change. m2c can't handle sizeof(long) so this needs to change or it'll throw errors.

Also the repo is already using submodules and updates them on setup, so it seemed fine to add another?

Oct 27 '22 09:10 Kelebek1

See the ramrom.h change. m2c can't handle sizeof(long) so this needs to change or it'll throw errors.

Please explain your use case and what this error is.

Oct 27 '22 10:10 RevoSucks

Is it still erroring on sizeof long?

Oct 29 '22 03:10 RevoSucks