pokemon-reverse-engineering-tools icon indicating copy to clipboard operation
pokemon-reverse-engineering-tools copied to clipboard

No Wram Execution Command Line Argument

Open anmart opened this issue 8 years ago • 1 comments

This is more of a suggestion with code to back it up than a commit. I tried using tcgdisasm.py and got a couple jumps to wram labels that I didn't want. Rather than fixing them manually, I thought it would be nice to have an argument that could force the disassembler to skip wram labels when considering calls or jumps.

I know very little about python and even less about the poketools, but I thought I'd give writing the modifications a shot. I'd just like for wram execution avoidance to be an option eventually.

edit: I realized this wasn't as clear as it could have been. In tcgdisasm.py (and I believe only this script), pointers in bank 3 were being replaced with wram labels because the disassembler assumed that they were addresses in bank 3. -nwe just enables the script to assume labels starting with "w" are not local labels.

anmart avatar Jun 04 '16 04:06 anmart

To be fair, tcgdisasm.py is a shitty edit of gbz80disasm.py that allows it to handle the farcall macro. But gbz80disasm.py just got completely remade the other day, so now tcgdisasm.py and gbz80disasm.py are nothing alike. This should probably be remade too.

dannye avatar Jun 04 '16 16:06 dannye