pokeemerald icon indicating copy to clipboard operation
pokeemerald copied to clipboard

Add the HEAL_LOCATION_NONE constant

Open sphericalice opened this issue 2 years ago • 1 comments

Description

Adds the HEAL_LOCATION_NONE constant and renames some variables (warp implies something different to healLocation imo). Also uses the TRY_FREE_AND_SET_NULL macro for when sFlyMap is freed in CB_ExitFlyMap.

Discord contact info

Spherical Ice#4683

sphericalice avatar Jun 03 '22 14:06 sphericalice

Looks good to me. Unfortunately this is going to cause issues with Porymap.

At the moment Porymap is responsible for writing include/constants/heal_locations.h, and it determines what constants should go in that file based on what's present in the table sHealLocations. HEAL_LOCATION_NONE isn't present in that table, and so the define will be removed and the user's repo won't build.

I'll mark it as a draft for now until (if ever) that's resolved on Porymap's end.

GriffinRichards avatar Jun 03 '22 14:06 GriffinRichards