pokeemerald icon indicating copy to clipboard operation
pokeemerald copied to clipboard

Published 20 hours ago • verified publisher icon pret

Replace mapjson with templates passed to jsonproc

Open Rangi42 opened this issue 2 years ago • 2 comments

tools/mapjson uses its own JSON parser (json11 instead of jsonproc's nlohmann/json), and hard-codes the details of the map-related files inside its C++ source. This is difficult to edit without knowing C++. It seems to me that the map-related files, like data/layouts/layouts.inc, could be generated the same way as wild data, with tools/jsonproc.

Rangi42 avatar Mar 21 '22 04:03 Rangi42

Might be able to make the whole generation process more repo-agnostic that way too

rawr51919 avatar Jun 19 '22 00:06 rawr51919

Also something to note: Would this in turn fix https://github.com/pret/pokeemerald/issues/1261?

rawr51919 avatar Jun 19 '22 01:06 rawr51919