pokeemerald icon indicating copy to clipboard operation
pokeemerald copied to clipboard

Published 20 hours ago • verified publisher icon pret

gbafix: Don't pad ELF files

Open aplumafreak500 opened this issue 3 years ago • 1 comments

If option -p is specified and the target file is an ELF, it will pad the ELF file. This shouldn't happen, as objcopy will pad it anyways.

A potential fix would be to ignore -p when the input is an ELF file, and possibly output a warning if this is the case.

aplumafreak500 avatar Dec 04 '20 13:12 aplumafreak500

Another possibility could be to just not use -p with ELF files

rawr51919 avatar Jun 17 '22 15:06 rawr51919

Assuming sh_offset gets set to something non-zero, this seems to have been fixed in 2019: https://github.com/pret/pokeemerald/blame/master/tools/gbafix/gbafix.c#L297?

mrgriffin avatar Jan 18 '23 22:01 mrgriffin