Map/object/event cleanup

[Rangi42]

Points carried over from #639 :

• [x] Map setup command constants vs. functions
• [x] map_warp_face vs. RestoreFacingAfterWarp are misnomers
• [ ] object_struct constant names should match WRAM labels
• [ ] *MapObject* -> *ObjectEvent*

[rawr51919]

Will this be worked on in some fashion? Next thing to do would be to resolve the misnomers that are map_warp_face and RestoreFacingAfterWarp.

[Rangi42]

No, this won't be worked on any more. :P

[rawr51919]

Might be easiest to do point 4, as all that entails is replacing every MapObject* label with a ObjectEvent* one, but would wMapObjects need to be renamed to wObjectEvents or nah?

[mid-kid]

Please read the linked Issue for details.

[vulcandth]

From reading the linked issue; Let's see if the following is what we want to do for point 4:

• map_object: MACRO => object_event: MACRO (And eventually MACRO object_event)
• MAPOBJECT_OBJECT_STUCT_ID => OBJECTEVENT_OBJECT_STRUCT_ID (and likewise for the rest)
• MAPOBJECT_LENGTH EQU _RS => OBJECTEVENT_LENGTH EQU _RS (And eventually DEF OBJECTEVENT_LENGTH EQU _RS)
• wMapObjects => wObjectEvents

What about the following:

• wCurMapObjectEventCount
• wCurMapObjectEventsPointer
• wTempObjectCopyMapObjectIndex
• The map_object* file names... example (constants/map_object_constants.asm).

I'm just trying to determine the scope of this, and if it is something I can create a PR for.

[Rangi42]

object_event, and generally *_event, is used within map scripts already.