presto icon indicating copy to clipboard operation
presto copied to clipboard

[Native] Avoid streaming aggregation when source is NestedLoopJoin

Open karteekmurthys opened this issue 8 months ago • 8 comments

Description

This is a fix to avoid this issue https://github.com/prestodb/presto/issues/22585. Prestissimo creates a StreamingAgg when there are pregrouped keys in the AggregationNode. This assumption breaks when the source to the Aggregation is a NestedLoopJoin.

This change checks for the source node and avoids adding pre-grouped keys to the Aggregation Node if the source is nestedloop join.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • [ ] Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • [ ] If release notes are required, they follow the release notes guidelines.
  • [ ] Adequate tests were added if applicable.
  • [ ] CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

karteekmurthys avatar Jun 13 '24 02:06 karteekmurthys