presto icon indicating copy to clipboard operation
presto copied to clipboard

Update build configs with jdk 11

Open wanglinsong opened this issue 1 year ago • 2 comments

Description

Use JDK 11 to build Presto, and run tests.

Motivation and Context

This is the first step to upgrading Java versions, to catch up with the development of the Java ecosystem.

Impact

  • No public interface impact.
  • Will need to run performance tests.

Test Plan

Build and deploy Presto using Docker to evaluate performance impact.

Contributor checklist

  • [ ] Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • [ ] If release notes are required, they follow the release notes guidelines.
  • [ ] Adequate tests were added if applicable.
  • [ ] CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Upgrade the Java build version to JDK 11 :pr:`22656`

Notes

  • Some test suites are still runing on JDK8, especially those require docker-compose-based test environments. Individual PRs will be created to address them.

wanglinsong avatar May 02 '24 06:05 wanglinsong

This failure might be related:

Error: com.facebook.presto.operator.aggregation.TestKllSketchStateSerializer.testEstimatedMemorySizeString Time elapsed: 0.009 s <<< FAILURE! java.lang.AssertionError: estimated memory size error for sketch stream size 512 was > 5%: 0.20 expected [true] but found [false] at org.testng.Assert.fail(Assert.java:110) at org.testng.Assert.failNotEquals(Assert.java:1413) at org.testng.Assert.assertTrue(Assert.java:56) at

If it isn't please file an issue fir the flaky test.

elharo avatar May 02 '24 16:05 elharo

Nit: suggest change to the release note entry based on the Order of changes in the Release Notes Guidelines.

== RELEASE NOTES ==

General Changes
* Upgrade the Java build version to JDK 11 :pr:`22656`

steveburnett avatar May 29 '24 14:05 steveburnett