presto
presto copied to clipboard
Add support for Filelist caching for symlink tables
Test plan - (Please fill in how you tested your changes)
Using the hive catalog access the symlink tables by adding following properties:
hive.file-status-cache-expire-time=24h
hive.file-status-cache-size=100000000
hive.file-status-cache-tables=*
Metrics Queries -
presto> SELECT * FROM jmx.current."com.facebook.presto.hive:name=<catalog>,type=cachingdirectorylister";
presto> SELECT "listlocatedstatuscalls.totalcount", "listobjectscalls.totalcount", "liststatuscalls.totalcount" from jmx.current."com.facebook.presto.hive.s3:name=<catalog>,type=prestos3filesystem";
== RELEASE NOTES ==
Hive Changes
* Add support for Filelist caching for symlink tables
I'm sorry, I missed this earlier. @zhenxiao, I have updated the commit with tests. Please review.
Hi @zhenxiao, Could you please take a pass on this?
@zhenxiao Looks like after rebasing, the Jmx values in the test are not coming up after caching. But earlier these JMX metrics were populating fine. And this test runs fine from my Local IDE.
yep, let's try fix the testcase. Then we could merge :)