presto icon indicating copy to clipboard operation
presto copied to clipboard

Published 20 hours ago • verified publisher icon prestodb

Fix flaky distributed queue burst traffic test

Open lain-m21 opened this issue 2 years ago • 3 comments

Do the following 2 things to make sure the burst traffic test works fine

  • Increase the resource group refresh interval to make sure only the allowed numbers of queries running
  • Increase the timeout of the test to make sure the test completes

Test plan - Unit test

== NO RELEASE NOTE ==

lain-m21 avatar Sep 15 '22 15:09 lain-m21

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: lain-m21 / name: Lain Matsuoka (3e3a5a5f9624129aa3411a5232732727a000f1a6)

linux-foundation-easycla[bot] avatar Sep 15 '22 15:09 linux-foundation-easycla[bot]

The once flaky test (like this) is fixed. I confirmed this by running the test on local multiple times as well.

lain-m21 avatar Sep 16 '22 10:09 lain-m21

Changes look fine @lain-m21 . Can you test it with adding invocation count = 100, @Test(invocationCount = 100) so that we can ensure that the fix works as expected. Also worthwhile (can be a separate PR) is to understand the root cause for this flakiness.

ajaygeorge avatar Sep 16 '22 19:09 ajaygeorge