presto icon indicating copy to clipboard operation
presto copied to clipboard

added getScheme() implementation in PrestoS3FileSystem.java

Open pratyakshsharma opened this issue 2 years ago • 1 comments

Details in https://github.com/prestodb/presto/issues/18166

Test plan - (Please fill in how you tested your changes)

Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.

Fill in the release notes towards the bottom of the PR description. See Release Notes Guidelines for details.

== RELEASE NOTES ==

General Changes
* added getScheme() method in PrestoS3FileSystem.
* ...

Hive Changes
* ...
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

pratyakshsharma avatar Aug 11 '22 09:08 pratyakshsharma

@imjalpreet Can you please take the first pass here?

pratyakshsharma avatar Aug 11 '22 09:08 pratyakshsharma

@tdcmeehan please have a look. Let us merge this once you approve.

pratyakshsharma avatar Aug 17 '22 16:08 pratyakshsharma

@tdcmeehan ping!

pratyakshsharma avatar Aug 22 '22 09:08 pratyakshsharma

@pratyakshsharma Can you fix the commit message to be in imperative mood. something like Add getScheme implementation in PrestoS3FileSystem See https://cbea.ms/git-commit/

ajaygeorge avatar Aug 24 '22 17:08 ajaygeorge