presto icon indicating copy to clipboard operation
presto copied to clipboard

Upgrade to alluxio 2.8.1

Open beinan opened this issue 2 years ago • 1 comments

Test plan We might need to watch if there is any regression on production. Fix the Vulnerabilities from dependencies: CVE-2021-43859 CVE-2020-15250

== NO RELEASE NOTE ==

beinan avatar Aug 11 '22 00:08 beinan

@beinan There are compilation errors. Can you take a look.

 Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project presto-cache: Compilation failure
Error:  /home/runner/work/presto/presto/presto-cache/src/main/java/com/facebook/presto/cache/alluxio/CacheValidatingInputStream.java:[106,47] cannot find symbol
Error:    symbol:   variable NOT_SUPPORTED
Error:    location: class alluxio.exception.ExceptionMessage

ajaygeorge avatar Aug 11 '22 18:08 ajaygeorge

@beinan There are a few test failures . Can you take a look.

Error:  Failures: 
Error:    TestAlluxioCachingFileSystem.testBasicReadWithAsyncRestoreFailure:261->checkMetrics:468 expected [0] but found [90]
Error:    TestAlluxioCachingFileSystem.testSyncRestoreFailure » Test 
Method TestAlluxioCachingFileSystem.testSyncRestoreFailure()[pri:0, instance:com.facebook.presto.cache.alluxio.TestAlluxioCachingFileSystem@2ddc8ecb] should have thrown an exception of type class java.io.IOException
[INFO] 
Error:  Tests run: 47, Failures: 2, Errors: 0, Skipped: 0

ajaygeorge avatar Aug 13 '22 00:08 ajaygeorge

LGTM

Thanks a lot for the review! @ajaygeorge Let me try to rerun the skipped ci

beinan avatar Aug 16 '22 21:08 beinan