presto icon indicating copy to clipboard operation
presto copied to clipboard

Use scheme for querying brokers as specified in the PinotConfig

Open lksvenoy-r7 opened this issue 3 years ago • 5 comments

Test plan - (Please fill in how you tested your changes) These changes have been tested in a Pinot Cluster.

== RELEASE NOTES ==
Pinot Changes
* Ensure pinot connector respects the https scheme property when executing a broker query

lksvenoy-r7 avatar Jan 07 '22 18:01 lksvenoy-r7

CLA Not Signed

This is a bugfix for the presto pinot connector. The connector does not respect the

pinot.use-https-for-broker
pinot.use-https-for-proxy

properties when executing a broker (or broker proxy) query.

If more work is needed on this PR, please let me know.

lksvenoy-r7 avatar Jan 07 '22 18:01 lksvenoy-r7

Thanks for the contribution. Could you please sign the CLA?

zacw7 avatar Jan 11 '22 17:01 zacw7

Thanks for the contribution. Could you please sign the CLA?

I've started the process, thank you

lksvenoy-r7 avatar Jan 12 '22 22:01 lksvenoy-r7

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions!

stale[bot] avatar Sep 21 '22 11:09 stale[bot]

Closing as this is no longer relevant

lksvenoy-r7 avatar Apr 14 '23 13:04 lksvenoy-r7