presto icon indicating copy to clipboard operation
presto copied to clipboard

Fix reading fixed_len_byte_array of length 9-16 in parquet

Open v-jizhang opened this issue 3 years ago • 4 comments

Cherry-pick of https://github.com/trinodb/trino/pull/9971 If the extra bytes are all zeros or all -1 for negative values, then the remaining bytes can be decoded as a short decimal.

Currently incorrect results are returned when a negative value is stored in fixed_len_byte_array of size 9-16 and read as a short decimal.

Co-authored-by: Raunaq Morarka [email protected]

== RELEASE NOTES ==

General Changes
* Fix reading fixed_len_byte_array of length 9-16 in parquet

v-jizhang avatar Nov 23 '21 19:11 v-jizhang

Done. Thanks

v-jizhang avatar Jan 07 '22 00:01 v-jizhang

nice, @v-jizhang how about we squash the 2 commits into 1?

zhenxiao avatar Jan 10 '22 05:01 zhenxiao

nice, @v-jizhang how about we squash the 2 commits into 1?

Done. Thanks for reviewing.

v-jizhang avatar Jan 11 '22 20:01 v-jizhang

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions!

stale[bot] avatar Sep 21 '22 11:09 stale[bot]