presto icon indicating copy to clipboard operation
presto copied to clipboard

Add support for user/password auth - Elasticsearch

Open v-jizhang opened this issue 3 years ago • 2 comments

Cherry-pick of https://github.com/trinodb/trino/pull/2591/commits/bd4b3dd0b77ece2d56d58a38834f952e3f970905

Co-authored-by: Martin Traverso [email protected]

Test plan - (Please fill in how you tested your changes)

== RELEASE NOTES ==

ElasticSearch Connector Changes
* Add support for Elasticsearch user and password authentication.
   :issue:`15909`

v-jizhang avatar Jul 27 '21 00:07 v-jizhang

Why hasn't this PR been submitted yet? Anyone knows some news?

abmn614 avatar Nov 22 '21 07:11 abmn614

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions!

stale[bot] avatar Sep 21 '22 08:09 stale[bot]

Reviewed in #15877

v-jizhang avatar Nov 30 '22 21:11 v-jizhang

hi @v-jizhang could you please resolved the conflict?

zhenxiao avatar Dec 12 '22 02:12 zhenxiao

looks good. @v-jizhang could you please take a look at the 2 failing tests?

zhenxiao avatar Dec 16 '22 21:12 zhenxiao

nice. thank you, @v-jizhang could you please merge the last commit into previous ones? I plan to merge this PR after the change

zhenxiao avatar Dec 17 '22 05:12 zhenxiao