presto
presto copied to clipboard
add new option to pass query string to spark launcher
Test plan - Add a test in Spark smoke testing : launch a query given as a parameter to the CLI
This allow to pass a --query
parameter to give a complete query script as a string
Fixes : #15945
Caveats : since airline 0.x is deprecated (#16236), we cannot mutualy exclude options so --file
and --query
are optional. I left 2 TODOs to fix this in the PR that will fix #16236
== RELEASE NOTES ==
General Changes
* add a new ``query`` argument to Spark launcher command to pass the query in the command line
@rguillome Hi, are you still working on this or it's ready for review, Do you think you can pass these checks so that we can get reviewed. Thanks, Rohan
Hi @rohanpednekar yes I'm still working on this. I let a TODO to work on mutual exclusion of query vs file parameter and I think this is mandatory to make a clean PR. So I will link this to another PR upgrading airline as well.
Hi @rohanpednekar,
I just finished the PR to upgrade to airline 2.x (#17308). It will permit to mutually exclude either the file
or query
argument.
Since it will merge I could change this PR and remove the TODO.
Regards,
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions!