presto-python-client icon indicating copy to clipboard operation
presto-python-client copied to clipboard

Fixed default http_scheme in Connection class from 'http' to 'https'

Open akuzmichov opened this issue 5 years ago • 2 comments

Http scheme is not supported and raises a ValueError. Yet it is the default value that is set in Connection constructor. We should either make https the default (as in this pull request), or at least add a http_scheme='https' argument to dbapi.connect method in the quick start section of the readme.

akuzmichov avatar Feb 18 '20 16:02 akuzmichov

CLA Check
One or more committers are not authorized under a signed CLA as indicated below. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

  • :x: Andrei Kuzmichov (8dbcb02dca96369b84ce7e9544fd0273cb509d8a)

CLA Missing ID CLA Not Signed

  • :x: The email address for the commit (8dbcb02dca96369b84ce7e9544fd0273cb509d8a) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.