presto-admin icon indicating copy to clipboard operation
presto-admin copied to clipboard

Published 20 hours ago • verified publisher icon prestodb

Refactor stop_host method to use topology

Open petroav opened this issue 8 years ago • 6 comments

  • Use requests instead of urllib because it handles connection reset errors better.
  • Use upload_topology to mimic behavior of stop_host.

petroav avatar Dec 07 '16 23:12 petroav

@rschlussel updated version that addresses your comments. I also added a commit that fixed the Connection reset errors I was seeing while building the offline installer.

petroav avatar Dec 13 '16 09:12 petroav

travis failures are real. It looks like you missed a few usages of stop_host

rschlussel-zz avatar Dec 13 '16 16:12 rschlussel-zz

looks good % fixing the test failures.

rschlussel-zz avatar Dec 14 '16 20:12 rschlussel-zz

Can you also revert the timeout increase (and make sure that this fixes the issue)?

rschlussel-zz avatar Dec 15 '16 18:12 rschlussel-zz

@petroav what's the status of this?

rschlussel-zz avatar Mar 03 '17 18:03 rschlussel-zz

@rschlussel I put this on pause since we were seeing all those UnixPoolConnectionError I thought I would wait until we fixed the intermittent errors before going forward with this. I just saw the Travis has actually been very stable for presto-admin so I might rebase this.

petroav avatar Mar 03 '17 20:03 petroav