presto-admin icon indicating copy to clipboard operation
presto-admin copied to clipboard

Remove usage of tox

Open kokosing opened this issue 8 years ago • 2 comments

tox requires that development workstation is equipped with two python installations (2.6 and 2.7). However it could be somehow difficult to achieve as some linux distribution no longer support usage of 2.6.

Notice that travis is able to test multiple version of python, see: https://docs.travis-ci.com/user/languages/python

kokosing avatar Jul 07 '16 07:07 kokosing

If Travis supports it, we can definitely use that; it's rare that there are issues with 2.6/2.7 support. But we can't stop testing Python 2.6 because that's the ancient version of Python that the Hadoop appliance has.

cawallin avatar Jul 07 '16 13:07 cawallin

I've been bit by 2.6/2.7 issues that tox has caught. I agree that we need to keep testing with 2.6, and tox is convenient for doing that locally.

I agree that if Travis has built-in tooling for testing with different versions, we should definitely use it.

ebd2 avatar Jul 11 '16 14:07 ebd2