presto-admin icon indicating copy to clipboard operation
presto-admin copied to clipboard

Changes to the plugin.py file to include the plugin remove_jar feature

Open nanaessuman opened this issue 9 years ago • 2 comments

I added "remove_jar" to plugin.jar to allow users to remove jars from directories when they add files with the add_jar feature.

nanaessuman avatar Jan 15 '16 15:01 nanaessuman

Thanks for the patch! We're excited to have a new contributor! A couple notes on testing: You should run 'make lint' to ensure that the code adheres to our style. It's best to test with at least one presto node on a different node from presto-admin. Usually we write product tests to be able to run this automatically, but it's a bit complicated to set up, so it's fine if you just verify manually.

rschlussel-zz avatar Jan 15 '16 16:01 rschlussel-zz

@nanaessuman Could you please address the comments from @rschlussel ? So we could merge this PR.

kokosing avatar Mar 03 '17 06:03 kokosing