Steven Presti
Steven Presti
(note this is landing first and then we do this https://github.com/coreos/butane/pull/622)
> I'm now trying to test manually, and while reading the documentation, I had a question: How can I be sure that my code is running locally? > > I...
Your approach is sound. It might make sense to create tests before making the functions. In this case in particular could be well suited for TDD, and just create a...
@yasminvalim the go 1.21 test should be fixed by https://github.com/coreos/butane/pull/505. steps to update branch assuming origin is your fork and upstream is ``` git fetch upstream git merge upstream/main git...
> @yasminvalim the go 1.21 test should be fixed by #505. > steps to update branch > assuming origin is your fork and upstream is Sorry I led you astray,...
@yasminvalim I am a bit confused because this https://github.com/coreos/butane/pull/486/commits/36f71f1e0d0660796212b1ab0dc50b1b91e3379c should not be a thing. after reverting your merge it should have put you in a place with only your other...
Thank you for working on this; from my perspective it LGTM. @travier I agree; we could have like a stable/latest file in both ignition/butane and just fetch it?
@dependabot rebase
oof >error: use of deprecated function `nix::errno::errno`: please use `Errno::last_raw()` instead --> src/io/hash.rs:161:29 | 161 | nix::errno::errno() | ^^^^^ | = note: `-D deprecated` implied by `-D warnings` = help:...
@c4rt0 any way I could ask you to take a look at updating the sig's on this?