screenshot-nodejs icon indicating copy to clipboard operation
screenshot-nodejs copied to clipboard

upgrade puppet to 1.6 and Dockerfile node version

Open mkirank opened this issue 6 years ago • 3 comments

mkirank avatar Aug 09 '18 07:08 mkirank

Is there a reason to move to node 10.x? 10 is not LTS yet unless I'm misreading the chart https://github.com/nodejs/Release#release-schedule

marcellerusu avatar Aug 09 '18 17:08 marcellerusu

https://github.com/GoogleChrome/puppeteer/blob/master/package.json#L8

puppeteer seems to support back to 6.4 but doesn't say anything (I can find) about preferences, I assume they stick with the current LTS version.

marcellerusu avatar Aug 17 '18 18:08 marcellerusu

Yeah, they still use https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md.

But I'm fine with updating to a newer version, if everything works OK. We're in Docker world, I'm not really worried that it's not a LTS.

VojtechVitek avatar Aug 17 '18 18:08 VojtechVitek